From 565afc7a56c520e8bf20dd8415d72481e861ed31 Mon Sep 17 00:00:00 2001
From: Jesse Luehrs <doy@tozt.net>
Date: Wed, 2 Mar 2011 22:28:34 -0600
Subject: more useful handling of attributes with no services defined

---
 lib/Bread/Board/Declare/Meta/Role/Attribute.pm | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

(limited to 'lib/Bread/Board/Declare')

diff --git a/lib/Bread/Board/Declare/Meta/Role/Attribute.pm b/lib/Bread/Board/Declare/Meta/Role/Attribute.pm
index 19ba8f7..23434e4 100644
--- a/lib/Bread/Board/Declare/Meta/Role/Attribute.pm
+++ b/lib/Bread/Board/Declare/Meta/Role/Attribute.pm
@@ -127,6 +127,8 @@ after attach_to_class => sub {
             : ()),
     );
 
+    my $tc = $self->has_type_constraint ? $self->type_constraint : undef;
+
     my $service;
     if ($self->has_block) {
         $service = Bread::Board::Declare::BlockInjection->new(
@@ -140,14 +142,21 @@ after attach_to_class => sub {
             value => $self->literal_value,
         );
     }
-    elsif ($self->has_type_constraint) {
-        my $tc = $self->type_constraint;
-        if ($tc->isa('Moose::Meta::TypeConstraint::Class')) {
-            $service = Bread::Board::Declare::ConstructorInjection->new(
-                %params,
-                class => $tc->class,
-            );
-        }
+    elsif ($tc && $tc->isa('Moose::Meta::TypeConstraint::Class')) {
+        $service = Bread::Board::Declare::ConstructorInjection->new(
+            %params,
+            class => $tc->class,
+        );
+    }
+    else {
+        $service = Bread::Board::Declare::BlockInjection->new(
+            %params,
+            block => sub {
+                die "Attribute " . $self->name . " did not specify a service."
+                  . " It must be given a value through the constructor or"
+                  . " writer method before it can be resolved."
+            },
+        );
     }
 
     $self->associated_service($service) if $service;
-- 
cgit v1.2.3