Rename chars used as numbers to int8_t/uint8_t. Fix some other type usage.

This should help against the signed char problems, and is good for
code readability.  Now, if you have a char, it's either an untyped
in-memory byte, or a symbol inside a string.  Small numbers are instead
[u]int8_t, ints, an enum type, or, in so many cases, bools.

I didn't touch any of the tiles code, as it's currently broken and I don't
want to risk making it unbroken harder.

1 files changed, 4 insertions, 4 deletions

diff --git a/crawl-ref/source/artefact.h b/crawl-ref/source/artefact.h
index cee9270c09..2bfd83db49 100644
--- a/crawl-ref/source/artefact.h
+++ b/crawl-ref/source/artefact.h
@@ -61,13 +61,13 @@ struct unrandart_entry
     const char *unid_name;   // un-id'd name of unrandart
 
     object_class_type base_type;
-    unsigned char     sub_type;
+    uint8_t           sub_type;
     short             plus;
     short             plus2;
-    unsigned char     colour;       // colour of ura
+    uint8_t           colour;       // colour of ura
 
     short         value;
-    unsigned char flags;
+    uint8_t       flags;
 
     short prpty[ART_PROPERTIES];
 
@@ -116,7 +116,7 @@ std::string artefact_name( const item_def &item, bool appearance = false );
 
 const char *unrandart_descrip( int which_descrip, const item_def &item );
 
-int find_okay_unrandart(unsigned char aclass, unsigned char atype = OBJ_RANDOM,
+int find_okay_unrandart(uint8_t aclass, uint8_t atype = OBJ_RANDOM,
                         unrand_special_type specialness = UNRANDSPEC_EITHER,
                         bool in_abyss = false);