Remove HANDS_HALF.

1.5-handed weapons were supposed to be differentiated from 1-handed weapons
by having larger penalties to accuracy, damage, and delay when used with a
shield with not enough Shields skill. This was not a very large difference,
especially since it disappeared after raising Shields skill; the main
effect was making trident + shield less good in the early game for
fighters. And confusing players, of course.

In fact, bugs were present ever since 0.10 that meant that 1.5-handed
weapons actually had the same penalties to damage and delay as 1-handed
weapons. So instead of putting those unnoticeable penalties back in, let's
remove HANDS_HALF. A couple notes:

* This commit shouldn't change which weapons are usable with a shield for
  any race. This required refactoring the code and changing some weapon
  sizes, but those sizes are only used to determine handedness and
  wieldability anyway. This is how the weapon sizes are currently used
  for one-handed weapons:
  - SIZE_LITTLE one-handed weapons are one-handed for everyone
  - SIZE_SMALL one-handed weapons are two-handed for spriggans only
  - SIZE_MEDIUM one-handed weapons are two-handed for all the small races

* Blowguns no longer have a small penalty for being used with a shield.
  This can be added back in if desired, but it was previously implemented
  using HANDS_HALF and seems fairly unimportant.

1 files changed, 0 insertions, 1 deletions

diff --git a/crawl-ref/source/attack.h b/crawl-ref/source/attack.h
index a61e3e15e0..7b9d96a6f2 100644
--- a/crawl-ref/source/attack.h
+++ b/crawl-ref/source/attack.h
@@ -51,7 +51,6 @@ public:
     item_def        *weapon;
     brand_type      damage_brand;
     skill_type      wpn_skill;
-    hands_reqd_type hands;
 
     // Attacker's shield, stored so we can reference it and determine
     // the attacker's combat effectiveness