diff options
author | Adam Borowski <kilobyte@angband.pl> | 2013-11-28 23:33:32 +0100 |
---|---|---|
committer | Adam Borowski <kilobyte@angband.pl> | 2013-11-29 01:07:35 +0100 |
commit | 5f4ae1ef05d92d9da03cde00b07d187f2f53a06d (patch) | |
tree | 01dbc85606ad5ab882333b1695c915b63e97b96d /crawl-ref/source/attitude-change.cc | |
parent | 2965f04181dcb6530b93acb194ba5f7561d8adc9 (diff) | |
download | crawl-ref-5f4ae1ef05d92d9da03cde00b07d187f2f53a06d.tar.gz crawl-ref-5f4ae1ef05d92d9da03cde00b07d187f2f53a06d.zip |
Replace `mpr(s, ch)` with `mprf(ch, s)`
Also simplify quite a few cases.
It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string. I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.
Diffstat (limited to 'crawl-ref/source/attitude-change.cc')
-rw-r--r-- | crawl-ref/source/attitude-change.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crawl-ref/source/attitude-change.cc b/crawl-ref/source/attitude-change.cc index 3f23bf2c7f..aff508fcc2 100644 --- a/crawl-ref/source/attitude-change.cc +++ b/crawl-ref/source/attitude-change.cc @@ -298,7 +298,7 @@ static void _print_good_god_holy_being_speech(bool neutral, { msg = do_mon_str_replacements(msg, mon); strip_channel_prefix(msg, channel); - mpr(msg.c_str(), channel); + mprf(channel, "%s", msg.c_str()); } } @@ -377,7 +377,7 @@ static void _print_converted_orc_speech(const string key, { msg = do_mon_str_replacements(msg, mon); strip_channel_prefix(msg, channel); - mpr(msg.c_str(), channel); + mprf(channel, "%s", msg.c_str()); } } |