diff options
author | Adam Borowski <kilobyte@angband.pl> | 2011-07-04 17:59:38 +0200 |
---|---|---|
committer | Adam Borowski <kilobyte@angband.pl> | 2011-07-05 02:21:51 +0200 |
commit | 06bb5b5c8199203001e4b3479351adf321299be5 (patch) | |
tree | c0bd4f83380fe5f3f408b3b605838e0d056b309b /crawl-ref/source/behold.cc | |
parent | eb03baac873c59367d8308b3c0a535b136f99633 (diff) | |
download | crawl-ref-06bb5b5c8199203001e4b3479351adf321299be5.tar.gz crawl-ref-06bb5b5c8199203001e4b3479351adf321299be5.zip |
cppcheck: fix inefficient checking for emptiness.
On some STL structures size() is slow. I did not bother limitting sed,
so innocent bystanders got pulled into the machine, but there's no loss.
Diffstat (limited to 'crawl-ref/source/behold.cc')
-rw-r--r-- | crawl-ref/source/behold.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crawl-ref/source/behold.cc b/crawl-ref/source/behold.cc index 30d490aff9..00c5389e88 100644 --- a/crawl-ref/source/behold.cc +++ b/crawl-ref/source/behold.cc @@ -107,7 +107,7 @@ monster* player::get_beholder(const coord_def &target) const monster* player::get_any_beholder() const { - if (beholders.size() > 0) + if (!beholders.empty()) return (&menv[beholders[0]]); else return (NULL); |