Let Orb run spawns generate in all non-abyss locations

Players have been picking up the Orb and entering a Zig only to
discover that Orb spawns don't generate, thus depriving them of HUGE
GUTS to RIP AND TEAR. Their complaints have been overwhelming, so now
Orb run spawns generate in Pan and all portals. We don't generate the
spawns in the Abyss, since the player can be banished there on the
ascension, whereas entering other places with the Orb is voluntary.

This commit also fixes the monster spawn rate when starting in the
abyss with Lucy, which was being set to the orb run spawn rate instead
of once per five turns as intended, and cleans up and documents some
functions.

1 files changed, 8 insertions, 4 deletions

diff --git a/crawl-ref/source/dbg-scan.cc b/crawl-ref/source/dbg-scan.cc
index d075f11aa9..0120decb4d 100644
--- a/crawl-ref/source/dbg-scan.cc
+++ b/crawl-ref/source/dbg-scan.cc
@@ -641,6 +641,13 @@ void debug_mons_scan()
 }
 #endif
 
+/**
+ * Check the map for validity, generating a crash if not.
+ *
+ * This checks the loaded map to make sure all dungeon features and shops are
+ * valid, all branch exits are generated, and all portals generated at fixed
+ * levels in the Depths are actually present.
+ */
 void check_map_validity()
 {
 #ifdef ASSERTS
@@ -692,12 +699,9 @@ void check_map_validity()
             portal = DNGN_UNSEEN;
         if (feat == exit || orig == exit)
             exit = DNGN_UNSEEN;
-
-
-
     }
 
-    if (portal && you.char_direction != GDT_ASCENDING)
+    if (portal)
     {
 #ifdef DEBUG_DIAGNOSTICS
         dump_map("missing_portal.map", true);