Refactor / remove some less important / unnecessary Gozag code.

In particular, the potion and shop lists don't need to be generated in
advance of using the ability altogether; they only last as long as the
ability menu is present (thus they're still stored, as if you get a HUP
in the middle of it we want to present the same choices).

Since shop prices no longer depend on the generated shops, item
generation for the shops is left to the shops. (If we want to preserve
their item quality, we'll need a level_number paramter in shop specs,
but I doubt players will notice the difference at all.)

RIP item_def::to_spec; you will not be missed.

1 files changed, 0 insertions, 3 deletions

diff --git a/crawl-ref/source/externs.h b/crawl-ref/source/externs.h
index 6652efff47..d37d7e0ff0 100644
--- a/crawl-ref/source/externs.h
+++ b/crawl-ref/source/externs.h
@@ -589,9 +589,6 @@ public:
     // Returns true if this item causes autoexplore to visit it.
     bool is_greedy_sacrificeable() const;
 
-    // Returns an item_spec for a non-artefact item.
-    string to_spec() const;
-
 private:
     string name_aux(description_level_type desc, bool terse, bool ident,
                     bool with_inscription, iflags_t ignore_flags) const;