Rename chars used as numbers to int8_t/uint8_t. Fix some other type usage.

This should help against the signed char problems, and is good for
code readability.  Now, if you have a char, it's either an untyped
in-memory byte, or a symbol inside a string.  Small numbers are instead
[u]int8_t, ints, an enum type, or, in so many cases, bools.

I didn't touch any of the tiles code, as it's currently broken and I don't
want to risk making it unbroken harder.

1 files changed, 3 insertions, 3 deletions

diff --git a/crawl-ref/source/ghost.h b/crawl-ref/source/ghost.h
index b2afe9b4a5..5f4a23ea68 100644
--- a/crawl-ref/source/ghost.h
+++ b/crawl-ref/source/ghost.h
@@ -14,7 +14,7 @@
 #include "mon-enum.h"
 #include "mon_resist_def.h"
 
-mon_attack_flavour ugly_thing_colour_to_flavour(unsigned char u_colour);
+mon_attack_flavour ugly_thing_colour_to_flavour(uint8_t u_colour);
 mon_resist_def ugly_thing_resists(bool very_ugly, mon_attack_flavour u_att_flav);
 
 class ghost_demon
@@ -37,7 +37,7 @@ public:
     mon_resist_def resists;
 
     bool spellcaster, cycle_colours;
-    unsigned char colour;
+    uint8_t colour;
     flight_type fly;
 
     monster_spells spells;
@@ -48,7 +48,7 @@ public:
     void init_random_demon();
     void init_player_ghost();
     void init_ugly_thing(bool very_ugly, bool only_mutate = false,
-                         unsigned char force_colour = BLACK);
+                         uint8_t force_colour = BLACK);
     void init_dancing_weapon(const item_def& weapon, int power);
     void ugly_thing_to_very_ugly_thing();