Make shadow creatures (and scrolls of summoning) no longer unholy

The spell was evidently only flagged unholy originally in response to
the spell description stating that the creatures were made from Abyssal
matter, a fact not at all not transparent in-game, nor which seems to
match how the spell behaves in other ways. For example, TSO still penalizes
unchivalrous attacks against intelligent living creatures created by the
spell, which seems dubious if they're just unholy matter in the first place,
vampiric draining works against them if they're living, and so forth.

Now that the spell will no longer summon creatures opposed by your god
anyway, it seems sensible that they would not disapprove of it.

1 files changed, 0 insertions, 6 deletions

diff --git a/crawl-ref/source/goditem.cc b/crawl-ref/source/goditem.cc
index 534c3809ad..f6ec981446 100644
--- a/crawl-ref/source/goditem.cc
+++ b/crawl-ref/source/goditem.cc
@@ -108,9 +108,6 @@ bool is_unholy_item(const item_def& item)
     case OBJ_WEAPONS:
         retval = is_demonic(item);
         break;
-    case OBJ_SCROLLS:
-        retval = (item.sub_type == SCR_SUMMONING);
-        break;
     case OBJ_BOOKS:
     case OBJ_RODS:
         retval = _is_bookrod_type(item, is_unholy_spell);
@@ -272,9 +269,6 @@ bool is_chaotic_item(const item_def& item)
     case OBJ_POTIONS:
         retval = (item.sub_type == POT_MUTATION);
         break;
-    case OBJ_SCROLLS:
-        retval = (item.sub_type == SCR_SUMMONING);
-        break;
     case OBJ_BOOKS:
     case OBJ_RODS:
         retval = _is_bookrod_type(item, is_chaotic_spell);