diff options
author | Neil Moore <neil@s-z.org> | 2014-07-07 16:45:50 -0400 |
---|---|---|
committer | Neil Moore <neil@s-z.org> | 2014-07-07 16:47:03 -0400 |
commit | bed3715938eb79407e51e692e2e0952857d0455b (patch) | |
tree | da6a4aa9bdfff0e33a3e56661f6ea7d6d80c57a3 /crawl-ref/source/items.cc | |
parent | 327597ee70d54c1740f807b3625d3d4aa064d8eb (diff) | |
download | crawl-ref-bed3715938eb79407e51e692e2e0952857d0455b.tar.gz crawl-ref-bed3715938eb79407e51e692e2e0952857d0455b.zip |
Adjust a comment (PleasingFungus)
It's not as easy to exploit as I thought. It might be possible on
Windows tiles (see #6486) but just a HUP won't do it.
Diffstat (limited to 'crawl-ref/source/items.cc')
-rw-r--r-- | crawl-ref/source/items.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/crawl-ref/source/items.cc b/crawl-ref/source/items.cc index 10bded7bca..f6b778bbc4 100644 --- a/crawl-ref/source/items.cc +++ b/crawl-ref/source/items.cc @@ -1693,10 +1693,11 @@ bool move_item_to_inv(int obj, int quant_got, bool quiet) you.pos()); } - // XXX: Waiting until now to decrement the quantity gives plenty of - // opportunity for the player to send a HUP and duplicate the item. - // However, we can't decrement the quantity before firing the position - // event, because the latter needs the object's index. + // XXX: Waiting until now to decrement the quantity may give Windows + // tiles players the opportunity to close the window and duplicate the + // item (a variant of bug #6486). However, we can't decrement the + // quantity before firing the position event, because the latter needs + // the object's index. dec_mitm_item_quantity(obj, quant_got); you.turn_is_over = true; |