diff options
| author | Adam Borowski <kilobyte@angband.pl> | 2013-11-28 23:33:32 +0100 |
|---|---|---|
| committer | Adam Borowski <kilobyte@angband.pl> | 2013-11-29 01:07:35 +0100 |
| commit | 5f4ae1ef05d92d9da03cde00b07d187f2f53a06d (patch) | |
| tree | 01dbc85606ad5ab882333b1695c915b63e97b96d /crawl-ref/source/l_colour.cc | |
| parent | 2965f04181dcb6530b93acb194ba5f7561d8adc9 (diff) | |
| download | crawl-ref-5f4ae1ef05d92d9da03cde00b07d187f2f53a06d.tar.gz crawl-ref-5f4ae1ef05d92d9da03cde00b07d187f2f53a06d.zip | |
Replace `mpr(s, ch)` with `mprf(ch, s)`
Also simplify quite a few cases.
It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string. I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.
Diffstat (limited to 'crawl-ref/source/l_colour.cc')
| -rw-r--r-- | crawl-ref/source/l_colour.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crawl-ref/source/l_colour.cc b/crawl-ref/source/l_colour.cc index 72136ba2ba..6bfa080a5c 100644 --- a/crawl-ref/source/l_colour.cc +++ b/crawl-ref/source/l_colour.cc @@ -60,7 +60,7 @@ static int _lua_element_colour(int rand, const coord_def& loc, lua_pushinteger(ls, loc.y); if (!dlua.callfn(NULL, 3, 1)) { - mpr(dlua.error.c_str(), MSGCH_WARN); + mprf(MSGCH_WARN, "%s", dlua.error.c_str()); return BLACK; } |