allow iterating over branches in a non-enum order (8742)

This allows us to have a consistent and logical ordering of branches
without requiring the branch enum itself to be reordered (which could
have save compatibility implications). The new ordering of branches just
moves Depths to the place in the ordering that it already is planned to
go on the next major save compat bump, but other changes are possible,
if desired. All places in the code that iterate over branches have been
updated to use the new iterator except for code dealing with save files,
which still uses enum order, so that we can change the display ordering
without affecting saves.

1 files changed, 6 insertions, 6 deletions

diff --git a/crawl-ref/source/l_you.cc b/crawl-ref/source/l_you.cc
index f287c5f087..54b2f54a43 100644
--- a/crawl-ref/source/l_you.cc
+++ b/crawl-ref/source/l_you.cc
@@ -626,21 +626,21 @@ LUAFN(you_in_branch)
 
     int br = NUM_BRANCHES;
 
-    for (int i = 0; i < NUM_BRANCHES; i++)
+    for (branch_iterator it; it; ++it)
     {
-        if (strcasecmp(name, branches[i].shortname) == 0
-            || strcasecmp(name, branches[i].longname) == 0
-            || strcasecmp(name, branches[i].abbrevname) == 0)
+        if (strcasecmp(name, it->shortname) == 0
+            || strcasecmp(name, it->longname) == 0
+            || strcasecmp(name, it->abbrevname) == 0)
         {
             if (br != NUM_BRANCHES)
             {
                 string err = make_stringf(
                     "'%s' matches both branch '%s' and '%s'",
                     name, branches[br].abbrevname,
-                    branches[i].abbrevname);
+                    it->abbrevname);
                 return luaL_argerror(ls, 1, err.c_str());
             }
-            br = i;
+            br = it->id;
         }
     }