Disambiguate the LOS_SOLID confusion.

Its name suggests it's about line of effect, while in fact it's both effect
and sight.  Thus, I've split its uses into LOS_SOLID and LOS_SOLID_SEE -- the
former is what LOS_SOLID was usually understood to mean, the latter is what it
actually was (being targettable with an arrow/beam).

The difference is: LOS_SOLID_SEE obeys clouds.

The name of the latter is abysmal -- if you have a better idea, please sed.

1 files changed, 1 insertions, 1 deletions

diff --git a/crawl-ref/source/los.cc b/crawl-ref/source/los.cc
index 2429a75528..c3c1fb8159 100644
--- a/crawl-ref/source/los.cc
+++ b/crawl-ref/source/los.cc
@@ -688,7 +688,7 @@ dungeon_feature_type ray_blocker(const coord_def& source,
     int blocked = 0;
     while (ray.pos() != target)
     {
-        blocked += opc_solid(ray.pos());
+        blocked += opc_solid_see(ray.pos());
         if (blocked >= OPC_OPAQUE)
             return (env.grid(ray.pos()));
         ray.advance();