Disambiguate the LOS_SOLID confusion.

Its name suggests it's about line of effect, while in fact it's both effect
and sight.  Thus, I've split its uses into LOS_SOLID and LOS_SOLID_SEE -- the
former is what LOS_SOLID was usually understood to mean, the latter is what it
actually was (being targettable with an arrow/beam).

The difference is: LOS_SOLID_SEE obeys clouds.

The name of the latter is abysmal -- if you have a better idea, please sed.

1 files changed, 7 insertions, 0 deletions

diff --git a/crawl-ref/source/losglobal.cc b/crawl-ref/source/losglobal.cc
index 4557febdec..b8600347a5 100644
--- a/crawl-ref/source/losglobal.cc
+++ b/crawl-ref/source/losglobal.cc
@@ -94,6 +94,13 @@ static void _update_globallos_at(const coord_def& p, los_type l)
             _save_los(&los, l);
             break;
         }
+    case LOS_SOLID_SEE:
+        {
+            los_def los(p, opc_solid_see);
+            los.update();
+            _save_los(&los, l);
+            break;
+        }
     default:
         die("invalid opacity");
     }