Revamp / simplify monster melee poison application

This removes AF_POISON_MEDIUM, leaving only AF_POISON and
AF_POISON_STRONG as the normal poison attack flavours, but basing
poison damage inflicted by attacker HD instead (AF_POISON_STRONG
inflicts more per HD, but importantly partially ignores rPois as
it presently does). Also it simplifies some of the random checks
for whether poison is inflicted at all.

In effect, this means that high HD monsters should inflict amounts
of poison that are more tactically relevant than present (which
seem generally desirable to me) while simplifying how they do so,
and keeping the poison damage from early creatures lower (as they
also have low HD).

Many creatures seem to fit a natural progression with this new
system, but there are several cases where monsters of the same HD
were explicitly differentiated by poison severity (such as scorpions,
with the same HD as adders but worse poison, or wolf spiders, with
more HD than any other spider but explicitly weaker poison). Some
of these will likely need individual changes.

1 files changed, 1 insertions, 1 deletions

diff --git a/crawl-ref/source/melee_attack.h b/crawl-ref/source/melee_attack.h
index 923bfce47b..f9ab3009b5 100644
--- a/crawl-ref/source/melee_attack.h
+++ b/crawl-ref/source/melee_attack.h
@@ -148,7 +148,7 @@ private:
     string mons_attack_verb();
     string mons_attack_desc();
     // TODO: Unify do_poison and poison_monster
-    void mons_do_poison();
+    bool mons_do_poison(bool always = false);
     void mons_do_napalm();
     void mons_do_eyeball_confusion();
     void apply_black_mark_effects();