Roll only once for identifying weapons by use.

You could tediously id anything by bashing a plant or throwing it at a wall,
with as little as 0.1 skill.  This is no more: every weapon has a secret
skill level needed to auto-id it.  You must know enough about the weapon to
possibly id it under the old system -- having wielded it once is enough, so
are certain other ways.  I intentionally didn't go into the complexity of
checking current curse status or blocking distortion/vamp.

Save compat: on training a weapon skill and certain other events for the
first time, you'll get unsightly ids of a bunch of items.  Probably not
worth any effort, you are very unlikely to get multiple ids at once during
normal play.

This commit does not handle missiles: they are mergeable and thus don't have
an unique random number, it would be enough to id one with the smallest
number and then merge stacks, you are currently encouraged to keep one of
every missile with different enchantments, etc.

1 files changed, 0 insertions, 1 deletions

diff --git a/crawl-ref/source/melee_attack.h b/crawl-ref/source/melee_attack.h
index cef5492799..209165063a 100644
--- a/crawl-ref/source/melee_attack.h
+++ b/crawl-ref/source/melee_attack.h
@@ -155,7 +155,6 @@ private:
     int  player_apply_weapon_skill(int damage);
     int  player_apply_fighting_skill(int damage, bool aux);
     int  player_apply_misc_modifiers(int damage);
-    void player_weapon_auto_id();
     int  player_stab_weapon_bonus(int damage);
     int  player_stab(int damage);