Replace `mpr(s, ch)` with `mprf(ch, s)`

Also simplify quite a few cases.

It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string.  I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.

1 files changed, 2 insertions, 2 deletions

diff --git a/crawl-ref/source/message-stream.cc b/crawl-ref/source/message-stream.cc
index 4b074359ee..e21e6f780b 100644
--- a/crawl-ref/source/message-stream.cc
+++ b/crawl-ref/source/message-stream.cc
@@ -73,7 +73,7 @@ namespace msg
         {
             // null-terminate and print the string
             internal_buf[internal_count] = 0;
-            mpr(internal_buf, channel, param);
+            mprf(channel, param, "%s", internal_buf);
 
             internal_count = 0;
 
@@ -85,7 +85,7 @@ namespace msg
 
         if (internal_count + 3 > INTERNAL_LENGTH)
         {
-            mpr("oops, hit overflow", MSGCH_ERROR);
+            mprf(MSGCH_ERROR, "oops, hit overflow");
             internal_count = 0;
             return streambuf::traits_type::eof();
         }