Replace `mpr(s, ch)` with `mprf(ch, s)`

Also simplify quite a few cases.

It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string.  I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.

1 files changed, 4 insertions, 4 deletions

diff --git a/crawl-ref/source/orb.cc b/crawl-ref/source/orb.cc
index 119fe06aeb..f04df9f69a 100644
--- a/crawl-ref/source/orb.cc
+++ b/crawl-ref/source/orb.cc
@@ -57,15 +57,15 @@ void orb_pickup_noise(const coord_def& where, int loudness, const char* msg, con
     if (_orb_noise(where, loudness))
     {
         if (msg)
-            mpr(msg, MSGCH_ORB);
+            mprf(MSGCH_ORB, "%s", msg);
         else
-            mpr("The orb lets out a hideous shriek!", MSGCH_ORB);
+            mprf(MSGCH_ORB, "The orb lets out a hideous shriek!");
     }
     else
     {
         if (msg2)
-            mpr(msg2, MSGCH_ORB);
+            mprf(MSGCH_ORB, "%s", msg2);
         else
-            mpr("The orb lets out a furious burst of light!", MSGCH_ORB);
+            mprf(MSGCH_ORB, "The orb lets out a furious burst of light!");
     }
 }