Replace `mpr(s, ch)` with `mprf(ch, s)`

Also simplify quite a few cases.

It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string.  I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.

1 files changed, 4 insertions, 4 deletions

diff --git a/crawl-ref/source/spl-goditem.cc b/crawl-ref/source/spl-goditem.cc
index 988917dbc6..27a56a1759 100644
--- a/crawl-ref/source/spl-goditem.cc
+++ b/crawl-ref/source/spl-goditem.cc
@@ -420,19 +420,19 @@ void antimagic()
     if (you.duration[DUR_TELEPORT] > 0)
     {
         you.duration[DUR_TELEPORT] = 0;
-        mpr("You feel strangely stable.", MSGCH_DURATION);
+        mprf(MSGCH_DURATION, "You feel strangely stable.");
     }
 
     if (you.duration[DUR_PETRIFYING] > 0)
     {
         you.duration[DUR_PETRIFYING] = 0;
-        mpr("You feel limber!", MSGCH_DURATION);
+        mprf(MSGCH_DURATION, "You feel limber!");
     }
 
     if (you.attribute[ATTR_DELAYED_FIREBALL])
     {
         you.attribute[ATTR_DELAYED_FIREBALL] = 0;
-        mpr("Your charged fireball dissipates.", MSGCH_DURATION);
+        mprf(MSGCH_DURATION, "Your charged fireball dissipates.");
     }
 
     if (you.attribute[ATTR_SWIFTNESS] > 0)
@@ -689,7 +689,7 @@ bool remove_curse(bool alreadyknown, string *pre_msg)
         learned_something_new(HINT_REMOVED_CURSE);
     }
     else if (alreadyknown)
-        mpr("None of your equipped items are cursed.", MSGCH_PROMPT);
+        mprf(MSGCH_PROMPT, "None of your equipped items are cursed.");
     else
     {
         if (pre_msg)