Cleanup/refactoring of tags.cc. No functional changes. I've been

running with and without this patch applied for about a week, and none
of my saves have broken, so I'm ready to commit it.

- Tag system no longer uses one big (shared!) global buffer.  This
  was the original impetus behind the change...
- Change every use of tagHeader into reader or writer (touches a lot).
- Split tagHeader into two classes: reader and writer.  Turns out
  every place that used tagHeader only cared about reading or writing
  and not about tags at all.  There was nothing left in tagHeader, so
  it disappeared along with a bunch of grotty special-case code.
- Not done: merge the files.cc read/writeThing code with the tags.cc
  marshall/unmarshallThing code.  This patch is big enough already.



git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@3685 c06c8d41-db1a-0410-9941-cceddc491573

1 files changed, 4 insertions, 4 deletions

diff --git a/crawl-ref/source/stash.cc b/crawl-ref/source/stash.cc
index f862c21044..dc77699437 100644
--- a/crawl-ref/source/stash.cc
+++ b/crawl-ref/source/stash.cc
@@ -136,14 +136,14 @@ static void fully_identify_item(item_def *item)
 
 static void save_item(FILE *file, const item_def &item)
 {
-    tagHeader th(file);
-    marshallItem(th, item);
+    writer outf(file);
+    marshallItem(outf, item);
 }
 
 static void load_item(FILE *file, item_def &item)
 {
-    tagHeader th(file);
-    unmarshallItem(th, item);
+    reader inf(file);
+    unmarshallItem(inf, item);
 }
 
 bool Stash::aggressive_verify = true;