Replace `mpr(s, ch)` with `mprf(ch, s)`

Also simplify quite a few cases.

It turns out in >90% cases of non-literals the argument had .c_str(),
which meant it was pointlessly malloc()ed and converted from and to
std::string.  I believe a sprintf is faster, so even the argument of
miniscule speed-up doesn't apply.

1 files changed, 3 insertions, 3 deletions

diff --git a/crawl-ref/source/view.cc b/crawl-ref/source/view.cc
index b039186082..751c4df3f1 100644
--- a/crawl-ref/source/view.cc
+++ b/crawl-ref/source/view.cc
@@ -301,12 +301,12 @@ void update_monsters_in_view()
         }
 
         if (size == 1)
-            mpr(msgs[0], MSGCH_WARN);
+            mprf(MSGCH_WARN, "%s", msgs[0].c_str());
         else
         {
             while (types.size() > max_msgs && !genera.empty())
                 _genus_factoring(types, genera);
-            mpr(_desc_mons_type_map(types), MSGCH_WARN);
+            mprf(MSGCH_WARN, "%s", _desc_mons_type_map(types).c_str());
         }
 
         bool warning = false;
@@ -342,7 +342,7 @@ void update_monsters_in_view()
             warning_msg += ".";
         }
         if (warning)
-            mpr(warning_msg, MSGCH_GOD);
+            mprf(MSGCH_GOD, "%s", warning_msg.c_str());
     }
 
     // Xom thinks it's hilarious the way the player picks up an ever