| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This allows us to have a consistent and logical ordering of branches
without requiring the branch enum itself to be reordered (which could
have save compatibility implications). The new ordering of branches just
moves Depths to the place in the ordering that it already is planned to
go on the next major save compat bump, but other changes are possible,
if desired. All places in the code that iterate over branches have been
updated to use the new iterator except for code dealing with save files,
which still uses enum order, so that we can change the display ordering
without affecting saves.
|
| |
|
|
|
|
|
| |
The chance to trigger the deleted-level-on-exiting-a-Zig bug was quite small,
thus I believe all affected games should have moved on already.
This reverts commit 7d816dcee34cf224c9f77a0d99a75f1ef375b05a.
|
| |
|
|
| |
It's not a proper fix, but it at leasts allows affected games to continue.
|
| | |
|
| |
|
|
|
|
| |
'you' seemed to be pointless in such context anyways, and lead to some
const correctness bugs since '*this' could have a different const-ness
from 'you'.
|
| |
|
|
|
|
|
|
|
|
|
| |
Our fault: enum types are not guaranteed to allow storing any values outside
defined values, and the compiler is allowed to reduce storage size if it
wants to. Since version 3.3, clang prefers unsigned types here. We used
-1 and -2 as magic values, which would then fail comparison.
I did not preserve the value of PlaceInfo.branch of -2 (ie, uninitialized).
The whole branch field is mostly redundant, though, and we can get rid of
it once get_all_place_info() is refactored.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I had to rename distance() (in coord.h) to distance2() because it conflicts
with the STL function to compare 2 iterators. Not a bad change given how it
returns the square of the distance anyway.
I also had to rename the message global variable (in message.cc) to buffer.
I tried to fix and improve the coding style has much as I could, but I
probably missed a few given how huge and tedious it is.
I also didn't touch crawl-gdb.py, and the stuff in prebuilt, rltiles/tool
and util/levcomp.*, because I have no clue about those.
|
| | |
|
| | |
|
| |
|
|
|
| |
It's still too overzealous, but at least won't ever trigger during normal
operation. It'd be nice to be able to delete levels from the outside.
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
It had not been useful since the 0.9 skill system overhaul, and often
had negative values because training happened before calculating the
gain. This removes the field entirely, as well as the associated
column "F" of the kills_by_place table. The old column "G" is now
calculated based on level XP only.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
As a side effect, branches can now be shortened without breaking major save
compat.
This commit itself doesn't preserve compat though, even though it'd be easy
-- other parts are too nasty already.
|
| |/ |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This will enable players who fell victim to the PlaceInfo bug to
continue their games as soon as CDO updates trunk.
This change should be reverted after some time has passed, preferably
when the next major version change comes around.
|
| |
|
|
|
| |
With thanks to Syllogism's throw-away comment on Something Awful.
I hadn't realized it was _that_ easy. :)
|
| |
|
