| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Sometimes, they're there to emphasize a break between two sections of code,
which is good. In a majority of cases, though, they're just inconsistent.
|
| | |
|
| | |
|
| |
|
|
| |
These three did not properly handle self-assignment.
|
| |
|
|
|
|
| |
Committing separately as I'm not sure whether checking, for example,
ASSERT_RANGE(level, 1, 28) is that nice. Perhaps 27 + 1 could be better?
Perhaps some other syntax?
|
| |
|
|
|
|
|
| |
Convert conjunctive assertions into separate assertions. This ought to be correctness preserving. I ran the stress tests and didn't notice anything unusual. While I have confidence in it, if you are the slightest bit suspicious of this, please roll it back.
Found instances with `ASSERT(\([^(|]*\) && \([^)|]*\))`
Manually inspected each instance.
|
| |
|
|
| |
It doesn't really fit on the tile.
|
| |
|
|
|
|
| |
This removes the _transform_add_weapon hack, and shows all unmelded
equipment on statues and shields on liches; armour doesn't fit right
on the current lich tile so it is disabled.
|
| |
|
|
| |
Cut down their wings, or Durkon will be too afraid.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
The code for equipment-using form tiles is not fit for the task, so I used
a hack using regular player doll code instead. It draws the weapon behind
the tile instead of the front (and can't be easily fixed), and fails to draw
shields at all.
|
| |
|
|
|
| |
The perl one-liner I use for this had a bug where it didn't match "else"
at the end of a line (ie, most of the time).
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I had to rename distance() (in coord.h) to distance2() because it conflicts
with the STL function to compare 2 iterators. Not a bad change given how it
returns the square of the distance anyway.
I also had to rename the message global variable (in message.cc) to buffer.
I tried to fix and improve the coding style has much as I could, but I
probably missed a few given how huge and tedious it is.
I also didn't touch crawl-gdb.py, and the stuff in prebuilt, rltiles/tool
and util/levcomp.*, because I have no clue about those.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Checks for inappropriate combinations (possible due to the doll editor) are
really ugly, and in the editor you get series of tile parts that won't show
up. That's nothing new (nagas, etc), but points out how the doll editor is
unmaintained.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
For now, Beastly Appendage will grant claws instead of tentacles.
|
| |
|
|
|
| |
While adhering religiously to the 80 column limit tends to be often pointless,
173 column long lines are way, way over the edge from the other side.
|
| |
|
|
|
| |
It was strange that this short-lived effect was singled out while nothing
else is.
|
| |
|
|
|
|
|
| |
tilep_equ_weapon checked if the player's weapon is melded even though
it was also used for monster weapons. I also removed redundant checks
for the player's respective equipment slots from the other tilep_equ_*
functions.
|
| |
|
|
| |
They're displayed if the player has the mutation, is not an octopode, and is not wielding/wearing something in the hand. For non-octopodes, only Beastly Appendage gives tentacles, but once there's constriction, they should be considered as a normal and/or DS mutation.
|
| |
|
|
|
|
| |
Too angry to check if webtiles work, sorry.
The properties are the initial draft too -- need to decide who shouted
loudest during the debate and change it accordingly.
|
| | |
|
| |
|
|
|
|
| |
Conflicts:
crawl-ref/source/startup.cc
|
| |
|
|
|
| |
This probably never caused problems, but valgrind found it, so I fixed
it.
|
| |\
| |
| |
| |
| | |
There are some issues left, like incorrect wrapping in some cases, but
we can fix them later.
|
| | |\ |
|
| | |\ \ |
|
| | |\ \ \ |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Only iostreams functions are left; on Windows they don't support Unicode
so a workaround will be needed.
|
| | |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
"File:" is shown in your editor's status bar.
"Written by:" was used only for the first person who changed a file. We got
git for that now, and pre-DCSS history is so woefully inaccurate it doesn't
really matter.
|
| | |_|/
|/| |
| | |
| | | |
Only serves to make wizmode creating statues more tedious.
|
| | |/
|/|
| |
| |
| |
| |
| |
| | |
Galehar's your_name hack was a step in the right direction, but it was still
not fully clean. There's no reason to use you.attribute[] -- it has a benefit
of not requiring a minor tag (something that was even impossible in the past!),
but has its flaws like verbosity, being hard to read and not allowing using
proper types the compiler can use to give warnings.
|
| |/
|
|
|
|
| |
I did review it manually to find places where they made sense (like some
tables), but for a massive sed job like this there might be places that
I missed.
|
| | |
|
| |
|
|
|
|
|
| |
New species tile art is no longer required to conform to binary genders.
All references to player gender have been removed. All the art is still
there, but the default gender presentations have been swapped around
arbitrarily.
|
| |
|
|
| |
This way they don't have to be hardcoded in dolls.txt.
|
| | |
|
| |
|
|
| |
All player tile look-ups are now in tilepick-p.cc.
|
| |
|
|
|
|
| |
Most of it has gone into tilepick.h, but also into enum.h and
initfile.cc. Unlike tiles.h which was included everywhere, tilepick.h is
now only a dependency of about half the files.
|
| |
|
|
|
|
|
|
| |
This new type defines to unsigned int, but it cleans up a lot of the
int/unsigned int/short confusion all over the codebase for tile indices.
This commit also cleans up tiles code to use coord_def more and to change
function signatures to pass const refs and non-const pointers.
|
| |
|
|
|
|
| |
Added missing header <sys/stat.h>
Signed-off-by: Janne Lahdenpera <felirx@gmail.com>
|
|
|
No functional changes, just rearranging and exposing functions where
needed.
|
