From 12da69cb597ec7fbcfbb13db1ded5414147f812c Mon Sep 17 00:00:00 2001 From: Jesse Luehrs Date: Fri, 3 Sep 2010 16:08:38 -0500 Subject: use all @Basic plugins explicitly, so i can pass options --- lib/Dist/Zilla/PluginBundle/DOY.pm | 69 ++++++++++++++++++++------------------ 1 file changed, 37 insertions(+), 32 deletions(-) (limited to 'lib/Dist/Zilla') diff --git a/lib/Dist/Zilla/PluginBundle/DOY.pm b/lib/Dist/Zilla/PluginBundle/DOY.pm index 005d3be..40554b2 100644 --- a/lib/Dist/Zilla/PluginBundle/DOY.pm +++ b/lib/Dist/Zilla/PluginBundle/DOY.pm @@ -81,29 +81,44 @@ has github_url => ( }, ); -has extra_plugins => ( - is => 'ro', - isa => 'ArrayRef[Str]', - init_arg => undef, - lazy => 1, - default => sub { +has _plugins => ( + is => 'ro', + isa => 'ArrayRef[Str]', + lazy => 1, + default => sub { my $self = shift; [ - 'MetaConfig', - 'MetaJSON', - 'NextRelease', - 'CheckChangesHasContent', - 'PkgVersion', - 'PodCoverageTests', - 'PodSyntaxTests', - 'NoTabsTests', - 'EOLTests', - 'CompileTests', - 'Repository', - 'Git::Check', - 'Git::Tag', - 'BumpVersionFromGit', - $self->is_task ? 'TaskWeaver' : 'PodWeaver', + qw( + GatherDir + PruneCruft + ManifestSkip + MetaYAML + License + Readme + ExtraTests + ExecDir + ShareDir + MakeMaker + Manifest + TestRelease + ConfirmRelease + MetaConfig + MetaJSON + NextRelease + CheckChangesHasContent + PkgVersion + PodCoverageTests + PodSyntaxTests + NoTabsTests + EOLTests + CompileTests + Repository + Git::Check + Git::Tag + BumpVersionFromGit + ), + ($self->is_task ? 'TaskWeaver' : 'PodWeaver'), + ($self->is_test_dist ? 'FakeRelease' : 'UploadToCPAN'), ] }, ); @@ -150,19 +165,9 @@ around BUILDARGS => sub { sub configure { my $self = shift; - if ($self->is_test_dist) { - $self->add_bundle( - '@Filter' => { bundle => '@Basic', remove => ['UploadToCPAN'] } - ); - $self->add_plugins('FakeRelease'); - } - else { - $self->add_bundle('@Basic'); - } - $self->add_plugins( map { [ $_ => ($self->plugin_options->{$_} || {}) ] } - @{ $self->extra_plugins }, + @{ $self->_plugins }, ); } -- cgit v1.2.3-54-g00ecf