diff options
| author | Jesse Luehrs <doy@tozt.net> | 2010-11-13 09:02:46 -0600 |
|---|---|---|
| committer | Jesse Luehrs <doy@tozt.net> | 2010-11-13 09:02:46 -0600 |
| commit | ce38493ccaffb0867e6d891b041a03de0feb97a7 (patch) | |
| tree | 847a609e72612403d37c2d72df7958f73117bed8 | |
| parent | ebcc8ba8734ef1bb70c0df6fabfa7c41d1309e73 (diff) | |
| download | package-stash-xs-ce38493ccaffb0867e6d891b041a03de0feb97a7.tar.gz package-stash-xs-ce38493ccaffb0867e6d891b041a03de0feb97a7.zip | |
actually fix the memory leak in new()
| -rw-r--r-- | Stash.xs | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -274,11 +274,11 @@ new(class, package_name) if (!SvPOK(package_name)) croak("The constructor argument must be the name of a package"); - instance = newHV(); + instance = (HV*)sv_2mortal((SV*)newHV()); - hv_store(instance, "name", 4, package_name, 0); + hv_store(instance, "name", 4, SvREFCNT_inc(package_name), 0); namespace = gv_stashpv(SvPV_nolen(package_name), GV_ADD); - hv_store(instance, "namespace", 9, newRV_noinc((SV*)namespace), 0); + hv_store(instance, "namespace", 9, newRV_inc((SV*)namespace), 0); RETVAL = sv_bless(newRV_inc((SV*)instance), gv_stashpv(class, 0)); OUTPUT: |