diff options
| author | Jesse Luehrs <doy@tozt.net> | 2013-01-03 19:58:27 -0600 |
|---|---|---|
| committer | Jesse Luehrs <doy@tozt.net> | 2013-01-03 19:58:27 -0600 |
| commit | 23bce74bb13d59926df49ef497be9ed46dc4ebcb (patch) | |
| tree | 03a3e4596944a3fb517cd9d21b14f73b564c89aa | |
| parent | d4f755a790d60fee0757d406d397153d99f1649e (diff) | |
| download | package-stash-23bce74bb13d59926df49ef497be9ed46dc4ebcb.tar.gz package-stash-23bce74bb13d59926df49ef497be9ed46dc4ebcb.zip | |
apparently we're no longer leaky here
| -rw-r--r-- | xt/author/leaks-debug.t | 8 | ||||
| -rw-r--r-- | xt/author/leaks.t | 10 |
2 files changed, 1 insertions, 17 deletions
diff --git a/xt/author/leaks-debug.t b/xt/author/leaks-debug.t index 12a4f41..7435318 100644 --- a/xt/author/leaks-debug.t +++ b/xt/author/leaks-debug.t @@ -73,13 +73,9 @@ use Symbol; no_leaks_ok { $foo->add_symbol('&code_init' => sub { "foo" }); } "add_symbol code doesn't leak"; - { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' - ? "the pure perl implementation leaks here somehow" - : undef; no_leaks_ok { $foo->add_symbol('io_init' => Symbol::geniosym); } "add_symbol io doesn't leak"; - } is(exception { is(Foo->code_init, 'foo', "sub installed correctly") }, undef, "code_init exists"); @@ -191,10 +187,6 @@ use Symbol; } { - local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP' - && $Carp::VERSION ge '1.17') - ? "Carp is leaky on 5.12.2 apparently?" - : undef; my $foo = Package::Stash->new('Foo'); no_leaks_ok { eval { $foo->get_or_add_symbol('&blorg') }; diff --git a/xt/author/leaks.t b/xt/author/leaks.t index 65e1c6e..18ec601 100644 --- a/xt/author/leaks.t +++ b/xt/author/leaks.t @@ -71,13 +71,9 @@ use Symbol; no_leaks_ok { $foo->add_symbol('&code_init' => sub { "foo" }); } "add_symbol code doesn't leak"; - { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' - ? "the pure perl implementation leaks here somehow" - : undef; no_leaks_ok { $foo->add_symbol('io_init' => Symbol::geniosym); } "add_symbol io doesn't leak"; - } is(exception { is(Foo->code_init, 'foo', "sub installed correctly") }, undef, "code_init exists"); @@ -189,13 +185,9 @@ use Symbol; } { - local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP' - && $Carp::VERSION ge '1.17') - ? "Carp is leaky on 5.12.2 apparently?" - : undef; my $foo = Package::Stash->new('Foo'); no_leaks_ok { - eval { $foo->get_or_add_symbol('&blorg') }; + eval { $foo->add_symbol('&blorg') }; } "doesn't leak on errors"; } |