diff options
| author | Jesse Luehrs <doy@tozt.net> | 2011-08-30 01:21:40 -0500 |
|---|---|---|
| committer | Jesse Luehrs <doy@tozt.net> | 2011-08-30 01:21:40 -0500 |
| commit | 92b6eef309468251f4d4cf6be994c173cb5e4169 (patch) | |
| tree | 2531275f02dc9129159b499dd788bbd526a93016 | |
| parent | 7ef54f40657ca05b95a31e7c81c28c2446b2cf37 (diff) | |
| download | package-stash-92b6eef309468251f4d4cf6be994c173cb5e4169.tar.gz package-stash-92b6eef309468251f4d4cf6be994c173cb5e4169.zip | |
update leak tests
| -rw-r--r-- | xt/author/20-leaks.t | 20 | ||||
| -rw-r--r-- | xt/author/21-leaks-debug.t | 20 |
2 files changed, 28 insertions, 12 deletions
diff --git a/xt/author/20-leaks.t b/xt/author/20-leaks.t index c37df91..767b4f1 100644 --- a/xt/author/20-leaks.t +++ b/xt/author/20-leaks.t @@ -59,16 +59,24 @@ use Symbol; { my $foo = Package::Stash->new('Foo'); - { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' - ? "the pure perl implementation leaks here somehow" - : undef; no_leaks_ok { $foo->add_symbol('$scalar_init' => 1); + } "add_symbol scalar doesn't leak"; + no_leaks_ok { $foo->add_symbol('@array_init' => []); + } "add_symbol array doesn't leak"; + no_leaks_ok { $foo->add_symbol('%hash_init' => {}); + } "add_symbol hash doesn't leak"; + no_leaks_ok { $foo->add_symbol('&code_init' => sub { "foo" }); + } "add_symbol code doesn't leak"; + { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' + ? "the pure perl implementation leaks here somehow" + : undef; + no_leaks_ok { $foo->add_symbol('io_init' => Symbol::geniosym); - } "add_symbol doesn't leak"; + } "add_symbol io doesn't leak"; } is(exception { is(Foo->code_init, 'foo', "sub installed correctly") @@ -127,8 +135,8 @@ use Symbol; @{$foo->get_or_add_symbol('@ISA')} = @super; $foo->get_or_add_symbol('$glob'); } "get_or_add_symbol doesn't leak"; - { local $TODO = ($] < 5.010 || $Package::Stash::IMPLEMENTATION eq 'PP') - ? "undef scalars aren't visible on 5.8, or from pure perl at all" + { local $TODO = $] < 5.010 + ? "undef scalars aren't visible on 5.8" : undef; ok($foo->has_symbol('$glob')); } diff --git a/xt/author/21-leaks-debug.t b/xt/author/21-leaks-debug.t index 7c453e7..0b7963f 100644 --- a/xt/author/21-leaks-debug.t +++ b/xt/author/21-leaks-debug.t @@ -61,16 +61,24 @@ use Symbol; { my $foo = Package::Stash->new('Foo'); - { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' - ? "the pure perl implementation leaks here somehow" - : undef; no_leaks_ok { $foo->add_symbol('$scalar_init' => 1); + } "add_symbol scalar doesn't leak"; + no_leaks_ok { $foo->add_symbol('@array_init' => []); + } "add_symbol array doesn't leak"; + no_leaks_ok { $foo->add_symbol('%hash_init' => {}); + } "add_symbol hash doesn't leak"; + no_leaks_ok { $foo->add_symbol('&code_init' => sub { "foo" }); + } "add_symbol code doesn't leak"; + { local $TODO = $Package::Stash::IMPLEMENTATION eq 'PP' + ? "the pure perl implementation leaks here somehow" + : undef; + no_leaks_ok { $foo->add_symbol('io_init' => Symbol::geniosym); - } "add_symbol doesn't leak"; + } "add_symbol io doesn't leak"; } is(exception { is(Foo->code_init, 'foo', "sub installed correctly") @@ -129,8 +137,8 @@ use Symbol; @{$foo->get_or_add_symbol('@ISA')} = @super; $foo->get_or_add_symbol('$glob'); } "get_or_add_symbol doesn't leak"; - { local $TODO = ($] < 5.010 || $Package::Stash::IMPLEMENTATION eq 'PP') - ? "undef scalars aren't visible on 5.8, or from pure perl at all" + { local $TODO = $] < 5.010 + ? "undef scalars aren't visible on 5.8" : undef; ok($foo->has_symbol('$glob')); } |