From b5a45848e42a559b828c46167f98c507a3ac8fc3 Mon Sep 17 00:00:00 2001 From: groditi Date: Sat, 11 Jul 2009 01:02:45 +0000 Subject: do not override custom location in push_viewport --- Changes | 2 +- lib/Reaction/UI/FocusStack.pm | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/Changes b/Changes index fd95283..01d8ba4 100644 --- a/Changes +++ b/Changes @@ -9,7 +9,7 @@ Revision history for Reaction - Add 'action' attribute to Action viewport - Adapt widget and layout to changes - Add example of explicitly stating action to ComponentUI - + - Don't override custom location in push_viewport 0.002000 - 29 Apr 2008 - Update CheckUniques role to use around instead of overrides - Stop using ACCEPT_CONTEXT, use InstancePerContext instead diff --git a/lib/Reaction/UI/FocusStack.pm b/lib/Reaction/UI/FocusStack.pm index 0af90a8..cd218da 100644 --- a/lib/Reaction/UI/FocusStack.pm +++ b/lib/Reaction/UI/FocusStack.pm @@ -25,12 +25,11 @@ sub push_viewport { $loc = join('-', $self->loc_prefix, $loc); } my $vp = $class->new( - %create, - location => $loc, - focus_stack => $self, - (defined $tail ? ( outer => $tail ) : ()), # XXX possibly a bug in - #immutable? - ); + location => $loc, + %create, + focus_stack => $self, + (defined $tail ? ( outer => $tail ) : ()), # XXX possibly a bug in immutable? + ); if ($tail) { # if we already have a tail (non-empty vp stack) $tail->inner($vp); # set the current tail's inner vp to the new vp } else { # else we're currently an empty stack -- cgit v1.2.3-54-g00ecf