From ed7945948ed9effdc26b31edfe27799a9f6abc0d Mon Sep 17 00:00:00 2001 From: Jesse Luehrs Date: Tue, 9 Sep 2014 20:02:03 -0400 Subject: limit messages to 512 bytes still need to avoid actually reading in bytes past 512 in an incoming message --- src/client.rs | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/client.rs') diff --git a/src/client.rs b/src/client.rs index 3903fb7..c8f0d7b 100644 --- a/src/client.rs +++ b/src/client.rs @@ -142,6 +142,9 @@ impl Client { // \n isn't valid inside a message, so this should be fine. if the \n // we find isn't preceded by a \r, this will be caught by the message // parser. + // XXX we should only be reading 512 bytes here, and throwing an error + // otherwise - or else we could end up reading an unbounded amount of + // data into memory let buf = match self.conn().read_until(b'\n') { Ok(b) => b, Err(e) => return Err(IoError(e)), -- cgit v1.2.3-54-g00ecf