From a73ee64e3aa33f8669c79bd2c22089d8c5b3196d Mon Sep 17 00:00:00 2001 From: Jesse Luehrs Date: Fri, 4 Jul 2014 20:15:37 -0400 Subject: stop using eval here --- lib/Spreadsheet/ParseXLSX.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/Spreadsheet/ParseXLSX.pm b/lib/Spreadsheet/ParseXLSX.pm index 45c7250..72c8793 100644 --- a/lib/Spreadsheet/ParseXLSX.pm +++ b/lib/Spreadsheet/ParseXLSX.pm @@ -634,11 +634,9 @@ sub _extract_files { $self->_rels_for($wb_name) ); - my $strings_xml = eval { - $zip->memberNamed( $path_base - .( $wb_rels->find_nodes(qq) )[0]->att('Target') - )->contents; - }; + my ($strings_xml) = map { + $zip->memberNamed($path_base . $_->att('Target'))->contents + } $wb_rels->find_nodes(qq); my $styles_xml = $self->_parse_xml( $zip, -- cgit v1.2.3-54-g00ecf