summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorJesse Luehrs <doy@tozt.net>2011-08-02 01:15:43 -0500
committerJesse Luehrs <doy@tozt.net>2011-08-02 01:44:12 -0500
commitfa28785153da58de0024597ef6f360c9382aa478 (patch)
tree10a00854767517649187e74fcb0d1f4f2221df26 /lib
parent794dc9df98d2aaf2f143f32ac7dfa42fa46ce07e (diff)
downloadeval-closure-fa28785153da58de0024597ef6f360c9382aa478.tar.gz
eval-closure-fa28785153da58de0024597ef6f360c9382aa478.zip
but... that breaks memoization, so disable that for now
Diffstat (limited to 'lib')
-rw-r--r--lib/Eval/Closure.pm27
1 files changed, 7 insertions, 20 deletions
diff --git a/lib/Eval/Closure.pm b/lib/Eval/Closure.pm
index 42c20da..4a39ed2 100644
--- a/lib/Eval/Closure.pm
+++ b/lib/Eval/Closure.pm
@@ -36,16 +36,11 @@ String eval is often used for dynamic code generation. For instance, C<Moose>
uses it heavily, to generate inlined versions of accessors and constructors,
which speeds code up at runtime by a significant amount. String eval is not
without its issues however - it's difficult to control the scope it's used in
-(which determines which variables are in scope inside the eval), and it can be
-quite slow, especially if doing a large number of evals.
+(which determines which variables are in scope inside the eval).
-This module attempts to solve both of those problems. It provides an
-C<eval_closure> function, which evals a string in a clean environment, other
-than a fixed list of specified variables. It also caches the result of the
-eval, so that doing repeated evals of the same source, even with a different
-environment, will be much faster (but note that the description is part of the
-string to be evaled, so it must also be the same (or non-existent) if caching
-is to work properly).
+This module attempts to solve this problem. It provides an C<eval_closure>
+function, which evals a string in a clean environment, other than a fixed list
+of specified variables.
=cut
@@ -193,18 +188,10 @@ sub _clean_eval_closure {
return ($code, $e);
}
-{
- my %compiler_cache;
+sub _make_compiler {
+ my $source = _make_compiler_source(@_);
- sub _make_compiler {
- my $source = _make_compiler_source(@_);
-
- unless (exists $compiler_cache{$source}) {
- $compiler_cache{$source} = _clean_eval($source);
- }
-
- return @{ $compiler_cache{$source} };
- }
+ return @{ _clean_eval($source) };
}
$Eval::Closure::SANDBOX_ID = 0;