vivify globs properly, so they pick up the right magic

2 files changed, 40 insertions, 5 deletions

diff --git a/lib/Package/Stash/PP.pm b/lib/Package/Stash/PP.pm
index a831564..49cce98 100644
--- a/lib/Package/Stash/PP.pm
+++ b/lib/Package/Stash/PP.pm
@@ -182,7 +182,15 @@ sub add_symbol {
     }
     else {
         my $namespace = $self->namespace;
-        $namespace->{$name} ||= *{ Symbol::gensym() };
+        {
+            # using glob aliasing instead of Symbol::gensym, because otherwise,
+            # magic doesn't get applied properly.
+            # see <20120710063744.19360.qmail@lists-nntp.develooper.com> on p5p
+            local *__ANON__:: = $namespace;
+            no strict 'refs';
+            no warnings 'void';
+            *{"__ANON__::$name"};
+        }
 
         if (@_ > 2) {
             no warnings 'redefine';
diff --git a/t/isa.t b/t/isa.t
index ce852a6..f2e516f 100644
--- a/t/isa.t
+++ b/t/isa.t
@@ -12,11 +12,38 @@ use Package::Stash;
 
 {
     package Bar;
+    sub bar { }
 }
 
-my $stash = Package::Stash->new('Foo');
-my @ISA = ('Bar');
-@{$stash->get_or_add_symbol('@ISA')} = @ISA;
-isa_ok('Foo', 'Bar');
+{
+    my $stash = Package::Stash->new('Foo');
+    my @ISA = ('Bar');
+    @{$stash->get_or_add_symbol('@ISA')} = @ISA;
+    isa_ok('Foo', 'Bar');
+    isa_ok(bless({}, 'Foo'), 'Bar');
+}
+
+{
+    package Baz;
+    sub foo { }
+}
+
+{
+    my $stash = Package::Stash->new('Quux');
+    {
+        my $isa = $stash->get_or_add_symbol('@ISA');
+        @$isa = ('Baz');
+        isa_ok('Quux', 'Baz');
+        isa_ok(bless({}, 'Quux'), 'Baz');
+        ok(Quux->can('foo'));
+    }
+    {
+        my $isa = $stash->get_or_add_symbol('@ISA');
+        @$isa = ('Bar');
+        isa_ok('Quux', 'Bar');
+        isa_ok(bless({}, 'Quux'), 'Bar');
+        ok(Quux->can('bar'));
+    }
+}
 
 done_testing;