aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgroditi <groditi@03d0b0b2-0e1a-0410-a411-fdb2f4bd65d7>2007-10-25 23:39:00 +0000
committergroditi <groditi@03d0b0b2-0e1a-0410-a411-fdb2f4bd65d7>2007-10-25 23:39:00 +0000
commitc689b58e5038a591091020f85a67715460d3b3e7 (patch)
tree092d7bd8520287b295268e109957769e29016179
parenta4f82080351c17ad76981742a8e45231781f75fe (diff)
downloadreaction-c689b58e5038a591091020f85a67715460d3b3e7.tar.gz
reaction-c689b58e5038a591091020f85a67715460d3b3e7.zip
oddities with create fixed, bug in reflector
-rw-r--r--lib/Reaction/InterfaceModel/Reflector/DBIC.pm4
-rw-r--r--lib/Reaction/UI/CRUDController.pm1
-rw-r--r--t/lib/RTest/TestDB/Bar.pm4
-rw-r--r--t/lib/RTest/TestDB/Baz.pm3
-rw-r--r--t/lib/RTest/TestDB/Foo.pm2
5 files changed, 8 insertions, 6 deletions
diff --git a/lib/Reaction/InterfaceModel/Reflector/DBIC.pm b/lib/Reaction/InterfaceModel/Reflector/DBIC.pm
index 326770f..dbfb351 100644
--- a/lib/Reaction/InterfaceModel/Reflector/DBIC.pm
+++ b/lib/Reaction/InterfaceModel/Reflector/DBIC.pm
@@ -33,7 +33,7 @@ class DBIC, which {
implements build_collection_actions => as { {} };
implements build_default_object_actions => as { [ qw/Update Delete/ ] };
- implements build_default_collection_actions => as { [ 'Create' ] };
+ implements build_default_collection_actions => as { [ qw/Create DeleteAll/ ] };
implements build_builtin_object_actions => as {
{
@@ -45,7 +45,7 @@ class DBIC, which {
implements build_builtin_collection_actions => as {
{
Create => {name => 'Create', base => Create },
- DeleteAll => {name => 'DeleteAll', base => DeleteAll }
+ DeleteAll => {name => 'DeleteAll', base => DeleteAll, attributes => [] }
};
};
diff --git a/lib/Reaction/UI/CRUDController.pm b/lib/Reaction/UI/CRUDController.pm
index f416c93..1ff7d88 100644
--- a/lib/Reaction/UI/CRUDController.pm
+++ b/lib/Reaction/UI/CRUDController.pm
@@ -53,6 +53,7 @@ sub base :Action :CaptureArgs(0) {
my ($self, $c) = @_;
}
+#XXX candidate for futre optimization
sub get_collection {
my ($self, $c) = @_;
my $model = $c->model( $self->model_name );
diff --git a/t/lib/RTest/TestDB/Bar.pm b/t/lib/RTest/TestDB/Bar.pm
index 1af3f05..88cf670 100644
--- a/t/lib/RTest/TestDB/Bar.pm
+++ b/t/lib/RTest/TestDB/Bar.pm
@@ -31,7 +31,7 @@ __PACKAGE__->belongs_to(
{ 'foreign.id' => 'self.foo_id' }
);
-__PACKAGE__->meta->make_immutable;
-
+#__PACKAGE__->meta->make_immutable;
+__PACKAGE__->meta->make_immutable(inline_constructor => 0);
1;
diff --git a/t/lib/RTest/TestDB/Baz.pm b/t/lib/RTest/TestDB/Baz.pm
index 47cc019..1ac88a7 100644
--- a/t/lib/RTest/TestDB/Baz.pm
+++ b/t/lib/RTest/TestDB/Baz.pm
@@ -26,6 +26,7 @@ __PACKAGE__->set_primary_key('id');
__PACKAGE__->has_many('links_to_foo_list' => 'RTest::TestDB::FooBaz', 'baz');
__PACKAGE__->many_to_many('foo_list' => 'links_to_foo_list' => 'foo');
-__PACKAGE__->meta->make_immutable;
+#__PACKAGE__->meta->make_immutable;
+__PACKAGE__->meta->make_immutable(inline_constructor => 0);
1;
diff --git a/t/lib/RTest/TestDB/Foo.pm b/t/lib/RTest/TestDB/Foo.pm
index 7e3cd2f..20d0305 100644
--- a/t/lib/RTest/TestDB/Foo.pm
+++ b/t/lib/RTest/TestDB/Foo.pm
@@ -40,6 +40,6 @@ __PACKAGE__->many_to_many('baz_list' => 'links_to_baz_list' => 'baz');
}
-__PACKAGE__->meta->make_immutable;
+__PACKAGE__->meta->make_immutable(inline_constructor => 0);
1;