aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJesse Luehrs <doy@tozt.net>2013-02-28 16:59:24 -0600
committerJesse Luehrs <doy@tozt.net>2013-02-28 16:59:24 -0600
commit9d13c572504e290b4d71b8c6c8262fdc32cd824f (patch)
tree1d4ec12ced7850ef9e4b481aa17fcbeef2d0b3f9 /src
parent66d9d34dae5f5358ac07b581d80417841c2c109d (diff)
downloadscala-test-more-9d13c572504e290b4d71b8c6c8262fdc32cd824f.tar.gz
scala-test-more-9d13c572504e290b4d71b8c6c8262fdc32cd824f.zip
eh, skip all with no message isn't worth it, really
Diffstat (limited to 'src')
-rw-r--r--src/main/scala/org/perl8/test/package.scala24
-rw-r--r--src/main/scala/org/perl8/test/tap/Producer.scala8
-rw-r--r--src/test/scala/org/perl8/test/tap/TestBuilderTest.scala14
3 files changed, 6 insertions, 40 deletions
diff --git a/src/main/scala/org/perl8/test/package.scala b/src/main/scala/org/perl8/test/package.scala
index b18dc2f..d2b8373 100644
--- a/src/main/scala/org/perl8/test/package.scala
+++ b/src/main/scala/org/perl8/test/package.scala
@@ -8,35 +8,21 @@ package object test {
sealed trait Plan {
val plan: Int
- val skipAll: Boolean
- val message: Option[String]
+ val skipAll: Option[String]
}
case class NumericPlan (plan: Int) extends Plan {
- val skipAll = false
- val message = None
+ val skipAll = None
}
case object NoPlan extends Plan {
val plan = 0
- val skipAll = false
- val message = None
+ val skipAll = None
}
- case class SkipAll (msg: String) extends Plan {
+ case class SkipAll (message: String) extends Plan {
val plan = 0
- val skipAll = true
- val message = Some(msg)
- }
-
- case object SkipAllNoMessage extends Plan {
- val plan = 0
- val skipAll = true
- val message = None
- }
-
- object SkipAll {
- def apply () = SkipAllNoMessage
+ val skipAll = Some(message)
}
case class BailOutException (
diff --git a/src/main/scala/org/perl8/test/tap/Producer.scala b/src/main/scala/org/perl8/test/tap/Producer.scala
index 52c72c9..d432856 100644
--- a/src/main/scala/org/perl8/test/tap/Producer.scala
+++ b/src/main/scala/org/perl8/test/tap/Producer.scala
@@ -25,13 +25,7 @@ object Producer {
message.split("\n").map(m => "# " + m).mkString("\n")
def plan (plan: Plan): String =
- if (plan.skipAll) {
- val skip = "1..0 # SKIP"
- plan.message.map(m => skip + " " + m).getOrElse(skip)
- }
- else {
- "1.." + plan.plan
- }
+ plan.skipAll.map(m => "1..0 # SKIP " + m).getOrElse("1.." + plan.plan)
def bailOut: String =
"Bail out!"
diff --git a/src/test/scala/org/perl8/test/tap/TestBuilderTest.scala b/src/test/scala/org/perl8/test/tap/TestBuilderTest.scala
index d59541a..36ffb9b 100644
--- a/src/test/scala/org/perl8/test/tap/TestBuilderTest.scala
+++ b/src/test/scala/org/perl8/test/tap/TestBuilderTest.scala
@@ -190,20 +190,6 @@ class TestBuilderTest extends TestMore {
val output = new ByteArrayOutputStream
Console.withOut(output) {
Console.withErr(output) {
- val builder = new TestBuilder(SkipAll())
- }
- }
-
- val expected =
- "1..0 # SKIP\n"
-
- is(output.toString, expected)
- }
-
- subtest ("skip all with reason") {
- val output = new ByteArrayOutputStream
- Console.withOut(output) {
- Console.withErr(output) {
val builder = new TestBuilder(SkipAll("foo bar"))
}
}