diff options
| author | Jesse Luehrs <doy@tozt.net> | 2021-12-13 23:30:56 -0500 |
|---|---|---|
| committer | Jesse Luehrs <doy@tozt.net> | 2021-12-13 23:42:11 -0500 |
| commit | 905da12c2f7802ed842a94192f837d42f9c5f0ca (patch) | |
| tree | 139efb05ae9d7dc18a179f4a7a397d9ea9126f22 /src | |
| parent | 3bbf036e01b9c8314c1d52ea38dfa6e5a7cc9e3d (diff) | |
| download | vt100-rust-905da12c2f7802ed842a94192f837d42f9c5f0ca.tar.gz vt100-rust-905da12c2f7802ed842a94192f837d42f9c5f0ca.zip | |
clean up clippy stuff
Diffstat (limited to 'src')
| -rw-r--r-- | src/cell.rs | 1 | ||||
| -rw-r--r-- | src/grid.rs | 3 | ||||
| -rw-r--r-- | src/lib.rs | 4 | ||||
| -rw-r--r-- | src/row.rs | 1 | ||||
| -rw-r--r-- | src/screen.rs | 5 |
5 files changed, 3 insertions, 11 deletions
diff --git a/src/cell.rs b/src/cell.rs index 857c9e2..1b44461 100644 --- a/src/cell.rs +++ b/src/cell.rs @@ -10,7 +10,6 @@ pub struct Cell { attrs: crate::attrs::Attrs, } -#[allow(clippy::collapsible_if)] impl PartialEq<Self> for Cell { fn eq(&self, other: &Self) -> bool { if self.len != other.len { diff --git a/src/grid.rs b/src/grid.rs index bde6726..3c9b540 100644 --- a/src/grid.rs +++ b/src/grid.rs @@ -332,9 +332,6 @@ impl Grid { } let cell = self.drawing_cell(pos).unwrap(); if cell.has_contents() { - // not sure why this is triggering here, seems like a - // clippy bug - #[allow(clippy::option_if_let_else)] if let Some(prev_pos) = prev_pos { if prev_pos.row != i || prev_pos.col < self.size.cols @@ -33,14 +33,12 @@ //! ); //! ``` -// XXX this is broken with ale -// #![warn(clippy::cargo)] +#![warn(clippy::cargo)] #![warn(clippy::pedantic)] #![warn(clippy::nursery)] #![allow(clippy::cognitive_complexity)] #![allow(clippy::missing_const_for_fn)] #![allow(clippy::missing_panics_doc)] -#![allow(clippy::single_match)] #![allow(clippy::too_many_arguments)] #![allow(clippy::too_many_lines)] @@ -277,7 +277,6 @@ impl Row { // while it's true that most of the logic in this is identical to // write_contents_formatted, i can't figure out how to break out the // common parts without making things noticeably slower. - #[allow(clippy::too_many_lines)] pub fn write_contents_diff( &self, contents: &mut Vec<u8>, diff --git a/src/screen.rs b/src/screen.rs index c885242..24f461c 100644 --- a/src/screen.rs +++ b/src/screen.rs @@ -826,10 +826,7 @@ impl Screen { } } -// unclear why putting this attribute on the individual methods doesn't work -#[allow(clippy::unused_self)] impl Screen { - #[allow(clippy::too_many_lines)] fn text(&mut self, c: char) { let pos = self.grid().pos(); let size = self.grid().size(); @@ -1161,6 +1158,7 @@ impl Screen { } // CSI h + #[allow(clippy::unused_self)] fn sm(&mut self, params: &vte::Params) { // nothing, i think? if log::log_enabled!(log::Level::Debug) { @@ -1211,6 +1209,7 @@ impl Screen { } // CSI l + #[allow(clippy::unused_self)] fn rm(&mut self, params: &vte::Params) { // nothing, i think? if log::log_enabled!(log::Level::Debug) { |