Extract newgame character restrictions from newgame.cc.

The functions in the new ng-restr.cc are "pure": They don't
access global state; data is passed in via the new and
incomplete newgame_def.

Eventually, new_game should be split into something like
  newgame_def choose_game();
that doesn't access "you", and
  void setup_game(newgame_def);
that sets up the player.

Also get rid of player_size in favour of player::body_size. Rename
player_size_type to size_part_type since it's not really
player-specific (used in actor::body_size). Move parts of
player_genus, player::has_claws, body_size out into species.cc.

1 files changed, 4 insertions, 0 deletions

diff --git a/crawl-ref/source/jobs.cc b/crawl-ref/source/jobs.cc
index 07e1ae139e..5daaaada78 100644
--- a/crawl-ref/source/jobs.cc
+++ b/crawl-ref/source/jobs.cc
@@ -190,3 +190,7 @@ int ng_num_classes()
     return ARRAYSZ(old_jobs_order);
 }
 
+bool is_valid_job(job_type job)
+{
+    return (job >= 0 && job < NUM_JOBS);
+}